Fix missing Emphasis infotext #16837

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

Haoming02 wants to merge 1 commit into AUTOMATIC1111:dev from Haoming02:fix-emphasis

+4 −4

Contributor

Haoming02 commented Feb 10, 2025

Description

Simple Description: Currently, in certain situations (see Repro), the Emphasis parameter would be missing from the infotext
Summary of Changes: Moved the code that adds this parameter into create_infotext function

Repro

Enable Persistent cond cache in settings
Generate an image that contains emphasis
- notice the Emphasis: ... in infotext
Generate again with the exact same parameters (Seed can vary)
- notice the Emphasis: ... is now missing
Reload UI
Click the Read generation parameters button (↙️)
See the Override settings now shows up as a result

TL;DR: Currently, the Emphasis parameter is added during CLIP processing. So if you enable the Persistent cond cache, the CLIP no longer gets called in subsequent generations, thus missing the parameter.

Checklist

I have read contributing wiki page
I have performed a self-review of my own code
My code follows the style guidelines
My code passes tests


          fix missing Emphasis infotext

32319e1

Haoming02 requested review from AUTOMATIC1111, w-e-w and catboxanon as code owners

February 10, 2025 06:10

Collaborator

w-e-w commented Feb 10, 2025

I also notice the issue with the entirer sd_hijack_clip.py
I have a WIP that I haven't had time to finish

fix missing infotext cased by conds cache #16677

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

AUTOMATIC1111 Awaiting requested review from AUTOMATIC1111 AUTOMATIC1111 is a code owner

w-e-w Awaiting requested review from w-e-w w-e-w is a code owner

catboxanon Awaiting requested review from catboxanon catboxanon is a code owner

At least 0 approving reviews are required to merge this pull request.

Labels

None yet